代码优化

app/controller/admin/system/merchant/GzcLogs.php

@@ -71,39 +71,38 @@ class GzcLogs extends BaseController
     public function inGzc()
     { 
         $id = intval($this->request->param('id'));
-        $cursor = Db::table('rrx_gzc_logs')
+        $log = Db::table('rrx_gzc_logs')
             ->where('id', $id)
             ->where('gzc', 0)
             ->where('success', 0)
             ->where('pension', '>', 0)
-            ->cursor();
+            ->find();
+        
+        if(!$log){
+            return app('json')->fail('请选择未入账的记录', );
+        }
             
-        foreach($cursor as $log){
-            if (!$log){
-                return app('json')->fail('暂无记录');
-            }
-            $mobile= $log['mobile'];
-            $user_name =  Db::name('user_certification')->where('uid',$log['uid'])->value('user_name');
-            $user_card =  Db::name('user_certification')->where('uid',$log['uid'])->value('user_card');
-            $card_positive = Db::name('user_certification')->where('uid',$log['uid'])->value('card_positive');
-            $card_reverse = Db::name('user_certification')->where('uid',$log['uid'])->value('card_reverse');
-            if(!$mobile || !$user_name || !$user_card || !$card_positive || !$card_reverse){
-                return app('json')->fail('暂无记录');
-            }
-
-            //发起入账gzc
-            $OrderGzcRepository = app()->make(OrderGzcRepository::class);
-            $register = $OrderGzcRepository->register($mobile);
-            if($register['status'] != 200) return app('json')->fail('入账失败:'.$register['message']);
-            $uid = $register['data']['uid'] ?? 0;
-            if(!$uid) return app('json')->fail('创建或获取用户失败');
-            $certification = $OrderGzcRepository->certification($uid, $mobile, $user_name, $user_card, $card_positive, $card_reverse);
-            if($certification['status'] != 200) return app('json')->fail('实名认证失败:'.$certification['message']);
-            $gzc = $OrderGzcRepository->gzc($uid,$log['pension']);
-            if($gzc['status'] != 200) return app('json')->fail('入账失败:'.$gzc['message']);
-            $gzc_deposit_no = $gzc['data'];
-            $gzc_confirm_result = $gzc['message'];
+        $mobile= $log['mobile'];
+        $user_name =  Db::name('user_certification')->where('uid',$log['uid'])->value('user_name');
+        $user_card =  Db::name('user_certification')->where('uid',$log['uid'])->value('user_card');
+        $card_positive = Db::name('user_certification')->where('uid',$log['uid'])->value('card_positive');
+        $card_reverse = Db::name('user_certification')->where('uid',$log['uid'])->value('card_reverse');
+        if(!$mobile || !$user_name || !$user_card || !$card_positive || !$card_reverse){
+            return app('json')->fail('存在实名数据缺失');
         }
+
+        //发起入账gzc
+        $OrderGzcRepository = app()->make(OrderGzcRepository::class);
+        $register = $OrderGzcRepository->register($mobile);
+        if($register['status'] != 200) return app('json')->fail('入账失败:'.$register['message']);
+        $uid = $register['data']['uid'] ?? 0;
+        if(!$uid) return app('json')->fail('创建或获取用户失败');
+        $certification = $OrderGzcRepository->certification($uid, $mobile, $user_name, $user_card, $card_positive, $card_reverse);
+        if($certification['status'] != 200) return app('json')->fail('实名认证失败:'.$certification['message']);
+        $gzc = $OrderGzcRepository->gzc($uid,$log['pension']);
+        if($gzc['status'] != 200) return app('json')->fail('入账失败:'.$gzc['message']);
+        $gzc_deposit_no = $gzc['data'];
+        $gzc_confirm_result = $gzc['message'];
         $OrderMerchantRepository = app()->make(OrderMerchantRepository::class);
         $orderId = $OrderMerchantRepository->getNewOrderId('IN10');
         Db::table('rrx_gzc_logs')
@@ -119,7 +118,8 @@ class GzcLogs extends BaseController
             'success' => 1,
             'update_time' => date('Y-m-d H:i:s')
         ]);
-        return app('json')->success('发起成功');
+        
+        return app('json')->success('发起成功', $log);
     }
 
 
@@ -155,7 +155,7 @@ class GzcLogs extends BaseController
             $card_positive = Db::name('user_certification')->where('uid',$log['uid'])->value('card_positive');
             $card_reverse = Db::name('user_certification')->where('uid',$log['uid'])->value('card_reverse');
             if(!$mobile || !$user_name || !$user_card || !$card_positive || !$card_reverse){
-                return app('json')->fail('暂无记录');
+                return app('json')->fail('存在实名数据缺失');
             }
 
             //发起入账gzc